CSHARP-4455: Fix test assertation. #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryLukyanov
commented
Dec 16, 2022
| // in rare cases, the thrown error is "HttpRequest exception: AcceessDeniedException". That means you don't have authorization to perform the requested action. | ||
| // It more or less corresponds to the expected behavior here, but it's unclear why the same scenario triggers different exceptions. | ||
| // However, it looks harmless to slightly update the test assertation to avoid assertation failures on EG | ||
| AssertInnerEncryptionException<HttpRequestException>(ex, "Error in KMS response. HTTP status=400. Response body=\n{\"__type\":\"AccessDeniedException\"}"); |
There was a problem hiding this comment.
I'm not 100% confident that thrown exception in this (and similar) patches is HttpRequestException. But if no, we will see it and will be able to fix
There was a problem hiding this comment.
I will try to reproduce it before merging, but given that I saw this exception around 5 times in total during last few months, my attempts might be not enough to do it for sure, but at least we can try
There was a problem hiding this comment.
found and fixed. See for details.
BorisDog
approved these changes
Dec 16, 2022
...Driver.Tests/Specifications/client-side-encryption/prose-tests/ClientEncryptionProseTests.cs
Outdated
Show resolved
Hide resolved
...Driver.Tests/Specifications/client-side-encryption/prose-tests/ClientEncryptionProseTests.cs
Outdated
Show resolved
Hide resolved
…on/prose-tests/ClientEncryptionProseTests.cs Co-authored-by: BorisDog <[email protected]>
…on/prose-tests/ClientEncryptionProseTests.cs Co-authored-by: BorisDog <[email protected]>
BorisDog
pushed a commit
to BorisDog/mongo-csharp-driver
that referenced
this pull request
Dec 22, 2022
dnickless
pushed a commit
to dnickless/mongo-csharp-driver
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.